Add CI tests for parquet-variant crate and fix clippy
#7601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 4, 2025
scovich
approved these changes
Jun 4, 2025
| @@ -547,13 +542,13 @@ mod tests { | |||
| OffsetSizeBytes::Three | |||
| .unpack_usize(&buf_three, 0, 0) | |||
| .unwrap(), | |||
| 0x0302_01 | |||
There was a problem hiding this comment.
odd, I didn't think clippy took a stance on how to break up long numbers with _?
There was a problem hiding this comment.
It complained to me that they didn't have equal widths and suggested 0x0030_0201 which I felt was even more obscure so I just removed the _ entirely
mkarbo
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.
Rationale for this change
While doing local development I found there were several clippy failures in the parquet-variant crate which failed when running
cargo clippy --workspaceI fixed them to get a clean run and added some CI checks to avoid in the future
What changes are included in this PR?
parquet-variant(test, clippy, and compile)Are there any user-facing changes?
No, this is all internal work only