Move variant interop test to Rust integration test #7602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jun 4, 2025
| @@ -327,6 +327,10 @@ impl<'m, 'v> VariantArray<'m, 'v> { | |||
| todo!() | |||
| } | |||
|
|
|||
| pub fn is_empty(&self) -> bool { | |||
There was a problem hiding this comment.
this is required by clippy
| @@ -88,7 +88,7 @@ impl OffsetSizeBytes { | |||
| } | |||
|
|
|||
| #[derive(Clone, Debug, Copy, PartialEq)] | |||
| pub(crate) struct VariantMetadataHeader { | |||
| pub struct VariantMetadataHeader { | |||
There was a problem hiding this comment.
Since this in the public API, it needs to be pub as well
alamb
force-pushed
the
alamb/variant_tests
branch
from
77a1af7 to
0bdb8d6
Compare
mkarbo
reviewed
Jun 9, 2025
|
This is looking pretty neat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Rust integration tests (in
parquet-variant/tests) are compiled as a external program would be compiled and thus can only use the exposed API. This helps verify that the crate is usableWhat changes are included in this PR?
variant_interoptest (cargo test --test variant_interop)pubstructuresAre there any user-facing changes?
There are now pub APIs in the parquet-variant crate