Skip to content

Fix Grid Gantt tooltip showing wrong start date on queued/scheduled segments #68176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shashbha14 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

Fix Grid Gantt tooltip showing wrong start date on queued/scheduled segments #68176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airflow-core/src/airflow/ui/src/layouts/Details/Gantt/GanttTimeline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ const toTooltipSummary = (
return {
child_states: null,
max_end_date: dayjs(segment.x[1]).toISOString(),
min_start_date: dayjs(segment.x[0]).toISOString(),
min_start_date: segment.start_when ?? dayjs(segment.x[0]).toISOString(),
state: segment.state ?? null,
task_display_name: segment.y,
task_id: segment.taskId,
Expand Down
5 changes: 4 additions & 1 deletion airflow-core/src/airflow/ui/src/layouts/Details/Gantt/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ export type GanttDataItem = {
/** Source try times for tooltips (matches TaskInstance `*_when` fields). */
queued_when?: string | null;
scheduled_when?: string | null;
/** Actual task execution start_date — consistent across all segments of the same try. */
start_when?: string | null;
state?: TaskInstanceState | null;
taskId: string;
tryNumber?: number;
Expand Down Expand Up @@ -133,10 +135,11 @@ export const transformGanttData = ({
const queuedMs = queuedDttm === null ? undefined : dayjs(queuedDttm).valueOf();
const scheduledMs = scheduledDttm === null ? undefined : dayjs(scheduledDttm).valueOf();

// Include scheduled/queued times in tooltip data whenever the timestamps exist.
// Include scheduled/queued/start times in tooltip data whenever the timestamps exist.
const tryWhenForTooltip = {
...(scheduledMs === undefined ? {} : { scheduled_when: scheduledDttm }),
...(queuedMs === undefined ? {} : { queued_when: queuedDttm }),
...(startDate === null ? {} : { start_when: startDate }),
};

let endMs: number;
Expand Down
Loading