Fix Grid Gantt tooltip showing wrong start date on queued/scheduled segments#68176
Open
shashbha14 wants to merge 1 commit into
Open
Fix Grid Gantt tooltip showing wrong start date on queued/scheduled segments#68176shashbha14 wants to merge 1 commit into
shashbha14 wants to merge 1 commit into
Conversation
shashbha14
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #68174
The Gantt bar tooltip was showing a wrong "Start Date" when hovering over the queued part of a task. It was picking up the queued time as the start date instead of the actual execution start date. Hovering over the execution part showed the correct time.
The issue was in 'toTooltipSummary' ,it was using 'segment.x[0]' (left edge of the hovered segment) for 'min_start_date'. For the queued segment that's the queued time, not the actual start date.
Fixed by storing the real 'start_date' as 'start_when' on every 'GanttDataItem' and using that in 'toTooltipSummary' instead of 'segment.x[0]'. Now hovering any segment shows the same correct start date.
I used Claude (claude.ai) as an AI assistant for parts of this implementation.