Skip to content

Re-enable missing metric: dag_processing.last_duration.<dag_file> #61079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
o-nikolas wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −6
Open

Re-enable missing metric: dag_processing.last_duration.<dag_file> #61079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions airflow-core/src/airflow/dag_processing/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1195,10 +1195,11 @@ def process_parse_results(
run_count=run_count + 1,
)

# TODO: AIP-66 emit metrics
# file_name = Path(dag_file.path).stem
# Stats.timing(f"dag_processing.last_duration.{file_name}", stat.last_duration)
# Stats.timing("dag_processing.last_duration", stat.last_duration, tags={"file_name": file_name})
# Note: relative_fileloc has a None default. In practice it is always provided but code defensively here in case
if relative_fileloc is not None and stat.last_duration is not None:
file_name = Path(relative_fileloc).stem
Stats.timing(f"dag_processing.last_duration.{file_name}", stat.last_duration)
Stats.timing("dag_processing.last_duration", stat.last_duration, tags={"file_name": file_name})
Copy link
Member

@uranusjr uranusjr Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this doesn’t really matter in practice, but would it be better to log {"file_name": None} instead of not logging at all?

Copy link
Contributor Author

@o-nikolas o-nikolas Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that would get confusing if we had multiple instances where the fileloc was None. It's generally a very undefined situation that would confuse users if we emitted metrics for it I think.


if parsing_result is None:
# No DAGs were parsed - this happens for callback-only processing
Expand Down
8 changes: 6 additions & 2 deletions airflow-core/tests/unit/dag_processing/test_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,7 +717,6 @@ def test_dag_with_system_exit(self, configure_testing_dag_bundle):

@conf_vars({("core", "load_examples"): "False"})
@mock.patch("airflow.dag_processing.manager.Stats.timing")
@pytest.mark.skip("AIP-66: stats are not implemented yet")
def test_send_file_processing_statsd_timing(
self, statsd_timing_mock, tmp_path, configure_testing_dag_bundle
):
Expand All @@ -734,7 +733,12 @@ def test_send_file_processing_statsd_timing(
manager = DagFileProcessorManager(max_runs=1)
manager.run()

last_runtime = manager._file_stats[os.fspath(path_to_parse)].last_duration
file_info = DagFileInfo(
bundle_name="testing",
rel_path=Path("temp_dag.py"),
bundle_path=tmp_path,
)
last_runtime = manager._file_stats[file_info].last_duration
statsd_timing_mock.assert_has_calls(
[
mock.call("dag_processing.last_duration.temp_dag", last_runtime),
Expand Down