Re-enable missing metric: dag_processing.last_duration.<dag_file> #61079
+11
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This metric was intentionally disabled during AIP-66 development. These changes bring the metric back using relative_fileloc instead of dag_path.file
o-nikolas
requested review from
ephraimbuddy and
jedcunningham
as code owners
Contributor
Author
|
@jedcunningham As the original author, can you have a look at this one? Specifically curious to hear your thoughts on using |
uranusjr
reviewed
Jan 27, 2026
| if relative_fileloc is not None and stat.last_duration is not None: | ||
| file_name = Path(relative_fileloc).stem | ||
| Stats.timing(f"dag_processing.last_duration.{file_name}", stat.last_duration) | ||
| Stats.timing("dag_processing.last_duration", stat.last_duration, tags={"file_name": file_name}) |
Member
There was a problem hiding this comment.
I know this doesn’t really matter in practice, but would it be better to log {"file_name": None} instead of not logging at all?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This metric was intentionally disabled during AIP-66 development. These changes bring the metric back using relative_fileloc instead of dag_path.file
Was generative AI tooling used to co-author this PR?
Cline - Claude Opus 4.5
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.