Make rpc nodes enable_full_rpc #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregcusack
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was surprised that my RPC node didn't not support the full api. I could turn this on for the whole cluster with the
--full-rpccli flag, but it makes sense to me to allow voting validators to run without it.Changes in this PR:
-Add
--full-rpc-apito set ofenable_full_rpcnode flags. This should probably be merged regardless, because I think it is the intent of theenable_full_rpcconfig.enable_full_rpcflags. Only boot bootstrap and other voting validators with full rpc if--full-rpcis provided on boot. This is more controversial. We could add separate cli handling for rpc vs voting nodes to opt in/out of full-rpc. But I think most users will want RPC nodes to have full support.