Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove --full-rpc-api as default in startup_scripts.rs #56

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

gregcusack
Copy link
Collaborator

Removed the --full-rpc-api default for all validators in startup_script.rs.

PR #53 set --full-rpc-api as default for only RPC node.

Added support for --full-rpc-api in startup_scripts.rs

Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up after me!

@gregcusack
Copy link
Collaborator Author

so actually this will not work. we have a load balancer in front of the rpc nodes and the bootstrap. so if --full-rpc-api is not used, then the load balancer may send an rpc request to the bootstrap which doesn't have rpc enabled. so i'm going to add a fix to that as a separate PR so these can be merged back to back

@gregcusack gregcusack force-pushed the rm-full-rpc-default branch from 60b3f3c to 0e82b3e Compare July 26, 2024 23:15
@gregcusack
Copy link
Collaborator Author

updated so bootstrap is not behind load balancer when we run without --full-rpc-api.
exit immediately if no --full-rpc-api and no rpc nodes
update load balancer to serve websocket port 8900. need for client

@gregcusack gregcusack merged commit 97c6fd0 into anza-xyz:main Jul 29, 2024
1 check passed
@gregcusack gregcusack deleted the rm-full-rpc-default branch July 29, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants