Skip to content

fix: skip SHA computation for newly added files in PRs #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yoheidemachi wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

fix: skip SHA computation for newly added files in PRs #989

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/github/data/fetcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,13 +341,21 @@ export async function fetchGitHubData({
let changedFilesWithSHA: GitHubFileWithSHA[] = [];
if (isPR && changedFiles.length > 0) {
changedFilesWithSHA = changedFiles.map((file) => {
// Don't compute SHA for deleted files
// Don't compute SHA for deleted or added files - deleted files no longer
// exist, and added files may not exist yet if the PR branch hasn't been
// checked out (fetchGitHubData runs before setupBranch).
if (file.changeType === "DELETED") {
return {
...file,
sha: "deleted",
};
}
if (file.changeType === "ADDED") {
return {
...file,
sha: "added",
};
}

try {
// Use git hash-object to compute the SHA for the current file content
Expand Down