fix: skip SHA computation for newly added files in PRs#989
Open
yoheidemachi wants to merge 1 commit intoanthropics:mainfrom
Open
fix: skip SHA computation for newly added files in PRs#989yoheidemachi wants to merge 1 commit intoanthropics:mainfrom
yoheidemachi wants to merge 1 commit intoanthropics:mainfrom
Conversation
fetchGitHubData() runs before setupBranch(), so files marked as ADDED in a PR don't exist on disk yet when git hash-object is called. This caused fatal errors for PRs that add new files. Skip SHA computation for ADDED files (like we already do for DELETED), using "added" as the SHA placeholder. Fixes anthropics#979 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetchGitHubData()runs beforesetupBranch()inprepareTagMode(), so files marked asADDEDin a PR don't exist on disk yet whengit hash-objectis called. This causesfatal: could not open '<file>' for reading: No such file or directoryerrors for PRs that add new files.Changes
Skip SHA computation for
ADDEDfiles (like we already do forDELETED), using"added"as the SHA placeholder.Execution order
fetchGitHubData()— callsgit hash-objecton changed files (fails for ADDED files)setupBranch()— checks out PR branch (files become available, but too late)Closes #979