fix lint check issue on github ci #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxyucs
force-pushed
the
fix-make-lint-failure
branch
from
7b24957 to
8fde8a0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
wxyucs
force-pushed
the
fix-make-lint-failure
branch
3 times, most recently
from
f43acdb to
fcfad3a
Compare
wxyucs
force-pushed
the
fix-make-lint-failure
branch
2 times, most recently
from
fb8b864 to
1fd4b44
Compare
wxyucs
force-pushed
the
fix-make-lint-failure
branch
2 times, most recently
from
12b153d to
582e37a
Compare
Signed-off-by: wxy407827 <[email protected]>
wxyucs
force-pushed
the
fix-make-lint-failure
branch
from
582e37a to
abef51b
Compare
wxyucs
commented
Jan 6, 2025
Comment on lines
-17
to
-20
| - name: Set up Python | ||
| uses: actions/setup-python@v3 | ||
| with: | ||
| python-version: '3.10' |
There was a problem hiding this comment.
there is a pre-install python3.10 in the vsaglib/vsag:ubuntu image. use "actions/setup-python@v3" to install a new will cause another issue:
CMake Error at /usr/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
Could NOT find Python3 (missing: Python3_INCLUDE_DIRS Development.Module)
(found version "3.10.15")
Carrot-77
pushed a commit
to Carrot-77/vsag
that referenced
this pull request
Jan 16, 2025
Signed-off-by: wxy407827 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #296