Skip to content

Commit

Permalink
fix lint check issue on github ci (#297)
Browse files Browse the repository at this point in the history
Signed-off-by: wxy407827 <[email protected]>
  • Loading branch information
wxyucs authored Jan 6, 2025
1 parent 7124411 commit 6852879
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 6 deletions.
7 changes: 3 additions & 4 deletions .github/workflows/lcov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,9 @@ jobs:
image: vsaglib/vsag:ubuntu
steps:
- uses: actions/checkout@v4
- name: Set up Python
uses: actions/setup-python@v3
with:
python-version: '3.10'
- name: Link Python3.10 as Python
run: |
ln -s /usr/bin/python3 /usr/bin/python
- name: Install
run: |
python -m pip install --upgrade pip
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,12 @@ jobs:
clang-tidy-check:
name: Lint
runs-on: ubuntu-latest
container:
image: vsaglib/vsag:ubuntu
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Install clang-tidy
run: sudo apt install clang-tidy-15 -y
run: sudo apt install clang-tidy-15 -y && sudo ln -s /usr/bin/clang-tidy-15 /usr/bin/clang-tidy
- name: Run lint
run: make lint
run: make debug && make lint
1 change: 1 addition & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ if (ENABLE_TOOLS AND ENABLE_CXX11_ABI)
endif ()

set (CMAKE_CXX_STANDARD 17)
set (CMAKE_CXX_STANDARD_REQUIRED ON)

if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
if (CMAKE_CXX_COMPILER_VERSION VERSION_EQUAL 17 OR CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 17)
Expand Down

0 comments on commit 6852879

Please sign in to comment.