Skip to content

Commit 5610733

Browse files
wxyucszourunxin.zrx
authored andcommitted
fix lint check issue on github ci (antgroup#297)
Signed-off-by: wxy407827 <[email protected]>
1 parent c0c2cbb commit 5610733

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

.github/workflows/lcov.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,9 @@ jobs:
1414
image: vsaglib/vsag:ubuntu
1515
steps:
1616
- uses: actions/checkout@v4
17-
- name: Set up Python
18-
uses: actions/setup-python@v3
19-
with:
20-
python-version: '3.10'
17+
- name: Link Python3.10 as Python
18+
run: |
19+
ln -s /usr/bin/python3 /usr/bin/python
2120
- name: Install
2221
run: |
2322
python -m pip install --upgrade pip

.github/workflows/lint.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,12 @@ jobs:
1010
clang-tidy-check:
1111
name: Lint
1212
runs-on: ubuntu-latest
13+
container:
14+
image: vsaglib/vsag:ubuntu
1315
steps:
1416
- name: Checkout code
1517
uses: actions/checkout@v4
1618
- name: Install clang-tidy
17-
run: sudo apt install clang-tidy-15 -y
19+
run: sudo apt install clang-tidy-15 -y && sudo ln -s /usr/bin/clang-tidy-15 /usr/bin/clang-tidy
1820
- name: Run lint
19-
run: make lint
21+
run: make debug && make lint

CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,7 @@ if (ENABLE_TOOLS AND ENABLE_CXX11_ABI)
195195
endif ()
196196

197197
set (CMAKE_CXX_STANDARD 17)
198+
set (CMAKE_CXX_STANDARD_REQUIRED ON)
198199

199200
if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
200201
if (CMAKE_CXX_COMPILER_VERSION VERSION_EQUAL 17 OR CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 17)

0 commit comments

Comments
 (0)