Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Q3D busbar example with Matrix Reduction Operation #272

Merged
merged 11 commits into from
Dec 19, 2024

Conversation

tizianrot
Copy link
Collaborator

Description

1 -Added Matrix Reduction Operation as per User's Request
2- Upon Report Creating (line 180), category="ACL" seems not be read, not error given but report in the GUi is empty

Checklist

Please complete the following checklist before submitting your pull request:

  • [x ] I have followed the example template and guide lines to add/update an example.
  • [x ] I have tested the example locally and verified that it is working with the latest version of AEDT.
  • [ x] I have verified that these changes to the best of my knowledge do not introduce any security vulnerabilities.

2- Upon Report Creating (line 180), category="ACL" seems not be read, not error given but report in the GUi is empty
@gmalinve
Copy link
Collaborator

gmalinve commented Nov 22, 2024

@tizianrot I think that as soon as the post-processing part starts you could add a line explaining how to get available report categories with: q3d.post.available_quantities_categories() because I see that you specify the category in the get_traces_for_plot.

There are also 2 plots to fix by providing in context the reduced matrix name, for example:
q3d.post.create_report(expressions=data_reducedm2_plot_self, context=q3d.matrices[2].name)

- changed frequency sweep for better interpolation
fixed reduced matrix parameters plots
- moved report creation after solving to avoid errors upon rescaling xaxis to log
- changed frequency sweep setup command
@gmalinve gmalinve requested a review from anur7 December 12, 2024 13:03
gmalinve
gmalinve previously approved these changes Dec 12, 2024
Copy link
Collaborator

@gmalinve gmalinve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, finally fixed with main

@SMoraisAnsys SMoraisAnsys merged commit ba2ddb4 into main Dec 19, 2024
11 checks passed
@SMoraisAnsys SMoraisAnsys deleted the chore_q3d_example branch December 19, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please Add Matrix Red Operation in Q3D Busbar Example - Pull Request #272
4 participants