-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare module ec2_launch_template for promotion #2164
Prepare module ec2_launch_template for promotion #2164
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
This change depends on a change that failed to merge. Change ansible-collections/amazon.aws#2319 is needed. |
recheck |
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 24s (non-voting) |
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 21s (non-voting) |
This change depends on a change that failed to merge. Change ansible-collections/amazon.aws#2319 is needed. |
e2139a5
to
24ea7ae
Compare
Build failed. ❌ ansible-galaxy-importer FAILURE in 5m 51s (non-voting) |
24ea7ae
to
cbdd9d8
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 25s (non-voting) |
cbdd9d8
to
a74d629
Compare
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 4m 28s (non-voting) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few typo errors need to be fixed.
@@ -367,16 +409,37 @@ | |||
version_added: 3.1.0 | |||
type: str | |||
description: > | |||
- Wether the instance metadata endpoint is available via IPv6 (C(enabled)) or not (C(disabled)). | |||
- Wether the instance metadata endpoint is available via IPv6 (V(enabled)) or not (V(disabled)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Wether the instance metadata endpoint is available via IPv6 (V(enabled)) or not (V(disabled)). | |
- Whether the instance metadata endpoint is available via IPv6 (V(enabled)) or not (V(disabled)). |
dc4bfc1
to
79ac649
Compare
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 7m 38s (non-voting) |
Build succeeded (gate pipeline). ❌ ansible-galaxy-importer FAILURE in 4m 55s (non-voting) |
40d61f0
into
ansible-collections:main
…#2164) SUMMARY Depends-On: ansible-collections/amazon.aws#2319 Add some type hint for the module Use shared code from amazon.aws.plugins.module_utils.ec2 Add the possibility to delete specific version of a launch template Add support for tagging for launch template resource (Closes ansible-collections#176) Add the possibility to tag specific resources, not always instance and volume (Closes [ansible-collections#48](ansible-collections#48, Closes ansible-collections#2083) Support EBS Throughput (Closes ansible-collections#1944) Fix issue occurring when launch template contains more than 200 versions (Closes ansible-collections#2131) ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_launch_template Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin Reviewed-by: GomathiselviS <[email protected]>
…#2164) SUMMARY Depends-On: ansible-collections/amazon.aws#2319 Add some type hint for the module Use shared code from amazon.aws.plugins.module_utils.ec2 Add the possibility to delete specific version of a launch template Add support for tagging for launch template resource (Closes ansible-collections#176) Add the possibility to tag specific resources, not always instance and volume (Closes [ansible-collections#48](ansible-collections#48, Closes ansible-collections#2083) Support EBS Throughput (Closes ansible-collections#1944) Fix issue occurring when launch template contains more than 200 versions (Closes ansible-collections#2131) ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_launch_template Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin Reviewed-by: GomathiselviS <[email protected]>
SUMMARY
Depends-On: ansible-collections/amazon.aws#2319
amazon.aws.plugins.module_utils.ec2
ISSUE TYPE
COMPONENT NAME
ec2_launch_template