Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_launch_template: Add option to define custom throughput #1955

Closed

Conversation

KamilBlaz
Copy link

SUMMARY

Fixes #1944
Add throughput option to ec2_launch_template module in section block_device_mappings

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/bf981156980e4a8f81564704c90816d7

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection (non-voting)
build-ansible-collection POST_FAILURE in 14m 01s
✔️ ansible-test-splitter SUCCESS in 5m 08s
⚠️ integration-community.aws-1 SKIPPED Skipped due to failed job build-ansible-collection
Skipped 21 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/0c79717dbaf54a28953b39175c426747

✔️ ansible-galaxy-importer SUCCESS in 4m 31s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 50s
✔️ ansible-test-splitter SUCCESS in 4m 56s
✔️ integration-community.aws-1 SUCCESS in 16m 23s
Skipped 21 jobs

@markuman
Copy link
Member

@KamilBlaz thank you very much for your contribution.
Your PR needs at least a changelog fragment.
Furthermore, can you please append the integration test in tests/integration/targets/ec2_launch_template/?
otherwise looks good to me.

@markuman markuman added the backport-7 PR should be backported to the stable-7 branch label Nov 10, 2023
Copy link
Contributor

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KamilBlaz Thank you for taking time to work on this new feature. Can you please add a changelog fragment https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment for this functionality and cover with integration/unit tests?

description: >
The throughput to provision for a gp3 volume, with a maximum of 1,000 MiB/s.
Valid Range - Minimum value of 125. Maximum value of 1000.
type: int
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add version_added: 8.1.0

@alinabuzachis alinabuzachis removed the backport-7 PR should be backported to the stable-7 branch label May 17, 2024
@abikouo
Copy link
Contributor

abikouo commented Oct 7, 2024

@KamilBlaz Thanks for your contribution. Since the PR has not been updated and we are preparing the migration of this module, I have integrate the following changes into the PR #2164

@abikouo abikouo closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supports EBS throughput for ec2_launch_template.py
5 participants