Change variable names [UPDATED] #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what other variables should be renamed? |
Current coverage is 100% (diff: 100%)@@ master #34 diff @@
===================================
Files 5 5
Lines 165 165
Methods 0 0
Messages 0 0
Branches 0 0
===================================
Hits 165 165
Misses 0 0
Partials 0 0
|
|
@pratyushprakash, the reason I wanted others to take part in renaming variables is that since I authored the code, there might be a lot of things I implicitly understand, but that might not be true for other readers. What are your suggestions? Is there any part of the code you are unable to understand and can use better variables? Thank you. |
|
@pratyushprakash, can you please update the request at your earliest? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variable names have been changes as mentioned in Issue #31