Rename variables #33
Closed
Rename variables #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #33 diff @@
===================================
Files 5 5
Lines 165 165
Methods 0 0
Messages 0 0
Branches 0 0
===================================
Hits 165 165
Misses 0 0
Partials 0 0
|
Renames self.m to self.width and self.n to self.height in pycnn.py Related issue: #31
|
@nikssardana, thank you for your interest and help. In future, please go over the issue and make sure no one else is working on it before you start working on it, and comment on the issue that you are going to work on it, else there would be unnecessary duplications. There is already a similar PR #32. Edit: Your changes are not PEP8 compliant. Please check the compliance using flake8 before pushing the changes. Thanks. |
|
@nikssardana, I'm closing this request as this renaming has already been addressed in #32 and #34. The issue #31 still requires work. Please comment on the issue and let everyone know the part your working on and you can open another request. Thank you for your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames self.m to self.width and self.n to self.height in pycnn.py
Related issue: #31