Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename variables #31

Open
ankitaggarwal011 opened this issue Oct 8, 2016 · 9 comments
Open

Rename variables #31

ankitaggarwal011 opened this issue Oct 8, 2016 · 9 comments

Comments

@ankitaggarwal011
Copy link
Owner

ankitaggarwal011 commented Oct 8, 2016

Please note these guidelines while renaming variables.

  • Do not rename the parent class.
  • Rename the variables or methods to have more intuitive names.
  • Use private variables where necessary. You can use this or this guide.
  • Document the corresponding changes in README.

Any suggestions are welcome. Thanks.

@gregJohnRob
Copy link

What files would you like renamed? :)

@pratyushprakash
Copy link

Hi, can I take this up?

@ankitaggarwal011
Copy link
Owner Author

@gregJohnRob, the goal of this issue is to rename all the variables and methods in the code to ensure easier understandablity and readability. This will span over the entire code-base that can be improved. This is a subjective issue and would require thorough review.

@pratyushprakash, if @gregJohnRob isn't taking up this issue, you can go ahead. Please wait until he comment about it. Thanks.

@gregJohnRob
Copy link

@pratyushprakash I don't mind if you want to take it :)

@ankitaggarwal011
Copy link
Owner Author

@pratyushprakash, please let us know if you're working on this issue. Thanks.

@pratyushprakash
Copy link

@ankitaggarwal011 Yeah I'd be happy to.

@pratyushprakash
Copy link

I am no longer working on the issue. Please feel free to take it up as it still requires work. :)

@insomnious0x01
Copy link

Hello. This project looks interesting. I'll be happy to take a look at this issue. I'll let you know if I have any questions.

@ankitaggarwal011
Copy link
Owner Author

@dhetman, thanks. Please go ahead. Thank you for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants