-
Notifications
You must be signed in to change notification settings - Fork 58
Conversation
@anitab-org/qa-team can someone give this a quick test? updated dependency, so you will have to test whole apk |
ah the build fails because the flutter sdk used in github actions is 1.15. I have already updates this in #102 . We will have to merge that first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These slight changes look good to me 👍 lets wait for its verification through testing for its complete review .
@anitab-org/mentorship-flutter-maintainers can you review this. Thanks you |
@isabelcosta Can you review this? |
@isabelcosta can you merge this? Offline support PR #133 also depends on this |
Can you ask for one more review and someone to test the PR? So we follow the guidelines :) After that, I can totally merge. @techno-disaster |
@anitab-org/coding-team can someone review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@anitab-org/qa-team can someone please just run the flutter app and see if everything is working as is should? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the changes were tested locally [as can be seen from the following gif] and its working fine!! good job @techno-disaster 👍
Just a small query @isabelcosta how to reduce the size of the gifs as I don't know whenever i directly drop the gif in the comment section it just take a monster form 😆 .... 😄 |
The markdown works in the same way as HTML does. So you can use something like this :) :
|
hmm... i know this and i have tried this many times but this didn't work for me . will it work for gif ? hmmm ok lemme try ! oh!!! tried and not working as i said already BTW thanks for your reply 😄 |
@isabelcosta can we merge this now? |
Hey @isabelcosta , can we merge this now? a lot of PRs are being blocked by this. |
Description
Updated Bloc to 6.0.1
Fixes #116
Flutter Channel:
Type of Change:
Delete irrelevant options.
How Has This Been Tested?
Physical Device
Checklist:
Delete irrelevant options.