Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

chore: update bloc #117

Merged
merged 3 commits into from
Sep 3, 2020
Merged

Conversation

techno-disaster
Copy link
Contributor

Description

Updated Bloc to 6.0.1

Fixes #116

Flutter Channel:

  • I have used the Flutter Beta channel on my local machine

Type of Change:

Delete irrelevant options.

  • Code

How Has This Been Tested?

Physical Device

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

@techno-disaster techno-disaster added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Needs Review PR needs an additional review or a maintainer's review. Status: Needs Testing Work has been reviewed and needs the code tested by the quality assurance team. labels Jul 27, 2020
@techno-disaster
Copy link
Contributor Author

@anitab-org/qa-team can someone give this a quick test? updated dependency, so you will have to test whole apk

@techno-disaster
Copy link
Contributor Author

ah the build fails because the flutter sdk used in github actions is 1.15. I have already updates this in #102 . We will have to merge that first

@rpattath rpattath removed the Status: Needs Testing Work has been reviewed and needs the code tested by the quality assurance team. label Jul 28, 2020
robotjellyzone
robotjellyzone previously approved these changes Aug 1, 2020
Copy link

@robotjellyzone robotjellyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These slight changes look good to me 👍 lets wait for its verification through testing for its complete review .

@techno-disaster
Copy link
Contributor Author

@anitab-org/mentorship-flutter-maintainers can you review this. Thanks you

@techno-disaster
Copy link
Contributor Author

@isabelcosta Can you review this?

@techno-disaster
Copy link
Contributor Author

@isabelcosta can you merge this? Offline support PR #133 also depends on this

@isabelcosta
Copy link
Member

isabelcosta commented Aug 21, 2020

@isabelcosta can you merge this? Offline support PR #133 also depends on this

Can you ask for one more review and someone to test the PR? So we follow the guidelines :) After that, I can totally merge. @techno-disaster

@techno-disaster
Copy link
Contributor Author

@isabelcosta can you merge this? Offline support PR #133 also depends on this

Can you ask for one more review and someone to test the PR? So we follow the guidelines :) After that, I can totally merge. @techno-disaster

@anitab-org/coding-team can someone review this PR?

@isabelcosta isabelcosta requested review from a team and PrashanthPuneriya and removed request for a team August 23, 2020 18:33
@techno-disaster techno-disaster mentioned this pull request Aug 25, 2020
6 tasks
Copy link

@robotjellyzone robotjellyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@isabelcosta isabelcosta added Status: Needs Testing Work has been reviewed and needs the code tested by the quality assurance team. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Aug 28, 2020
@isabelcosta
Copy link
Member

@anitab-org/qa-team can someone please just run the flutter app and see if everything is working as is should?

Copy link

@robotjellyzone robotjellyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes were tested locally [as can be seen from the following gif] and its working fine!! good job @techno-disaster 👍

@robotjellyzone
Copy link

Just a small query @isabelcosta how to reduce the size of the gifs as I don't know whenever i directly drop the gif in the comment section it just take a monster form 😆 .... 😄

@garimasingh128
Copy link

garimasingh128 commented Aug 29, 2020

Just a small query @isabelcosta how to reduce the size of the gifs as I don't know whenever i directly drop the gif in the comment section it just take a monster form 😆 .... 😄

The markdown works in the same way as HTML does. So you can use something like this :) :

<div height="200" width="200">
<img src=".....">
</div>

@robotjellyzone
Copy link

robotjellyzone commented Aug 29, 2020

Just a small query @isabelcosta how to reduce the size of the gifs as I don't know whenever i directly drop the gif in the comment section it just take a monster form 😆 .... 😄

The markdown works in the same way as HTML does. So you can use something like this :) :

<div height="200" width="200">
<img src=".....">
</div>

hmm... i know this and i have tried this many times but this didn't work for me . will it work for gif ? hmmm ok lemme try ! oh!!! tried and not working as i said already BTW thanks for your reply 😄

@techno-disaster
Copy link
Contributor Author

@isabelcosta can we merge this now?

@techno-disaster
Copy link
Contributor Author

Hey @isabelcosta , can we merge this now? a lot of PRs are being blocked by this.

@isabelcosta isabelcosta merged commit 2d575be into anitab-org:develop Sep 3, 2020
@techno-disaster techno-disaster deleted the update-bloc branch September 4, 2020 02:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Needs Testing Work has been reviewed and needs the code tested by the quality assurance team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Bloc 6.0
5 participants