feat: add Task Comments #136

techno-disaster · 2020-08-25T00:33:51Z

Description

Add comments to tasks :) Haven't added names yet because it becomes too complicated to pass the data around. Zulip thread here

Fixes #111

Flutter Channel:

I have used the Flutter Beta channel on my local machine

Type of Change:

Delete irrelevant options.

Code

Code/Quality Assurance Only

New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Physical device

Checklist:

Delete irrelevant options.

My PR follows the style guidelines of this project
I have performed a self-review of my own code or materials
I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
Any dependent changes have been merged

Update bloc

techno-disaster · 2020-08-25T00:35:02Z

Depends on #117 again.

techno-disaster · 2020-09-03T02:09:05Z

@anitab-org/mentorship-flutter-maintainers any updates?

isabelcosta · 2020-09-03T17:27:06Z

@techno-disaster can you fix merge conflicts and we can move the ball forward :)

techno-disaster · 2020-09-09T13:53:25Z

@isabelcosta any updates?
@anitab-org/coding-team could anyone give this a quick review?

bartekpacia · 2020-09-09T20:03:16Z

i didn't look at this app in quite a long time and it's looking more and more amazing:)
good job, approving it

isabelcosta · 2020-09-09T21:59:25Z

pubspec.lock

@@ -643,7 +657,7 @@ packages:
      name: vector_math
      url: "https://pub.dartlang.org"
    source: hosted
-    version: "2.0.8"
+    version: "2.1.0-nullsafety.2"


out of curiosity what is the "nullsafety" bit? is this a stable version of the package?

Just an update in the flutter sdk. It supports strong null safety now.

isabelcosta · 2020-09-09T22:00:46Z

lib/remote/services/comment_service.chopper.dart

@@ -0,0 +1,53 @@
+// GENERATED CODE - DO NOT MODIFY BY HAND


again out of curiosity so that I start learning more about this code :)
What is this chopper for? Is this supposed to come in git?

@isabelcosta this is just built by build_runner . We can add this to gitignore, but if the testers wanted to test the app they would have to genrate these files on thier PC. This would affect the testing so we just decided to keep this aa it is

More info about this here

isabelcosta

Approving as this seems to be working as expected :)

isabelcosta · 2020-09-09T22:03:06Z

@anitab-org/qa-team can anyone test this PR please? this feature it's quite interesting :)
@techno-disaster, can you let us know where to find the APK?

techno-disaster · 2020-09-10T03:13:38Z

@anitab-org/qa-team can anyone test this PR please? this feature it's quite interesting :)
@techno-disaster, can you let us know where to find the APK?

Head on over to the checks tab . You will see a artifacts dropdown on that page. You can download a zip which contains a apk from that dropdown

techno-disaster · 2020-09-13T21:09:04Z

@anitab-org/qa-team any updates?

robotjellyzone

I have tested this pr and it's not working in the way it should.
The changes made in this PR were tested locally. Following are the results:

Code Review: Done
All possible responses were tested as below:
Screenshot/gif:

Expected Result: adding task comment
Actual Result: Not able to add task comment. giving out FormatException error

Additional testcases covered: n/a
Device : PIXEL XL API 28 PIE

techno-disaster · 2020-09-17T15:58:25Z

@isabelcosta @anitab-org/coding-team this seems like a backend issue? could you check the logs.

techno-disaster · 2020-09-17T15:59:37Z

@robotjellyzone did you build the apk on android studio or downloaded one from below the PR?

robotjellyzone · 2020-09-17T16:00:35Z

@robotjellyzone did you build the apk on android studio or downloaded one from below the PR?

on android studio

techno-disaster · 2020-09-17T16:51:34Z

@robotjellyzone did you build the apk on android studio or downloaded one from below the PR?

on android studio

ah ok so it looks like its the server bug. there's a issue for it already. can you try using the ursula account?

username : ursula
pwd: 12345678

robotjellyzone · 2020-09-17T17:17:43Z

@robotjellyzone did you build the apk on android studio or downloaded one from below the PR?

on android studio

ah ok so it looks like its the server bug. there's a issue for it already. can you try using the ursula account?

username : ursula
pwd: 12345678

hmm.. using this account , but its this using the same server/backend ? also, the PR should be generic and not specific i mean if it works for this account then it should also work using any ?

techno-disaster · 2020-09-20T13:55:20Z

@robotjellyzone did you build the apk on android studio or downloaded one from below the PR?

on android studio

ah ok so it looks like its the server bug. there's a issue for it already. can you try using the ursula account?
username : ursula
pwd: 12345678

hmm.. using this account , but its this using the same server/backend ? also, the PR should be generic and not specific i mean if it works for this account then it should also work using any ?

yes, it uses the same backend but even @yugantarjain faced this issue in which some accounts were able to make comments while others were getting internal server error. @isabelcosta can confirm this, we had a discussion on this in one of the sessions. So it shouldn't be blocking this PR

techno-disaster · 2020-09-20T13:57:09Z

@yugantarjain what accounts did you use for the comments feature? Almost all mine work if i setup the backend locallly, but were you able to get any account working on the one hosted on heroku?

techno-disaster · 2020-09-22T06:33:43Z

@anitab-org/mentorship-flutter-maintainers can you review this again? Also @robotjellyzone were you able to test comments? if you want a workaround for the backend error, you can check the completed comments on the ursula account. Comments work there

techno-disaster · 2020-11-17T21:02:11Z

@anitab-org/qa-team any updates on this PR?

isabelcosta · 2020-11-19T01:37:22Z

@techno-disaster make sure to also ping on Zulip, even invite newcomers to review the PR and test it :) This is advocate work, and can help onboard new people to the project.

Techno-Disaster added 9 commits July 27, 2020 18:11

migrated to 5.0

0207669

migrated to 6.0.1

80c70ab

Merge branch 'develop' into update-bloc

1a333f5

Merge pull request #17 from Techno-Disaster/update-bloc

27519f0

Update bloc

bloc and networking for comments done

2520de3

Delete token.txt

f15ca79

Comments done :)

2391e8d

fix backend url

ebb52ed

toast

dce3857

techno-disaster requested review from bartekpacia and isabelcosta as code owners August 25, 2020 00:33

techno-disaster added the Category: Coding Changes to code base or refactored code that doesn't fix a bug. label Aug 25, 2020

techno-disaster changed the title ~~Comments~~ feat: Comments Aug 25, 2020

Merge branch 'develop' into comments

3c99e67

bartekpacia previously approved these changes Sep 9, 2020

View reviewed changes

isabelcosta reviewed Sep 9, 2020

View reviewed changes

isabelcosta previously approved these changes Sep 9, 2020

View reviewed changes

isabelcosta added the Status: Needs Testing Work has been reviewed and needs the code tested by the quality assurance team. label Sep 9, 2020

isabelcosta changed the title ~~feat: Comments~~ feat: add Task Comments Sep 9, 2020

robotjellyzone suggested changes Sep 17, 2020

View reviewed changes

robotjellyzone added the Status: Changes Requested Changes are required to be done by the PR author. label Sep 17, 2020

fix merges

f6612a2

techno-disaster dismissed stale reviews from isabelcosta and bartekpacia via f6612a2 September 22, 2020 06:30

techno-disaster requested review from robotjellyzone, isabelcosta and bartekpacia September 22, 2020 06:32

isabelcosta removed the Status: Changes Requested Changes are required to be done by the PR author. label Sep 22, 2020

rpattath added Status: Needs Review PR needs an additional review or a maintainer's review. and removed Status: Needs Testing Work has been reviewed and needs the code tested by the quality assurance team. labels Oct 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add Task Comments #136

feat: add Task Comments #136

techno-disaster commented Aug 25, 2020

techno-disaster commented Aug 25, 2020

techno-disaster commented Sep 3, 2020

isabelcosta commented Sep 3, 2020

techno-disaster commented Sep 9, 2020

bartekpacia commented Sep 9, 2020

isabelcosta Sep 9, 2020

techno-disaster Sep 10, 2020

isabelcosta Sep 9, 2020

techno-disaster Sep 10, 2020

techno-disaster Sep 10, 2020

isabelcosta left a comment

isabelcosta commented Sep 9, 2020

techno-disaster commented Sep 10, 2020

techno-disaster commented Sep 13, 2020

robotjellyzone left a comment

techno-disaster commented Sep 17, 2020

techno-disaster commented Sep 17, 2020

robotjellyzone commented Sep 17, 2020 •

edited

Loading

techno-disaster commented Sep 17, 2020

robotjellyzone commented Sep 17, 2020 •

edited

Loading

techno-disaster commented Sep 20, 2020

techno-disaster commented Sep 20, 2020

techno-disaster commented Sep 22, 2020

techno-disaster commented Nov 17, 2020

isabelcosta commented Nov 19, 2020

feat: add Task Comments #136

Are you sure you want to change the base?

feat: add Task Comments #136

Conversation

techno-disaster commented Aug 25, 2020

Description

Flutter Channel:

Type of Change:

How Has This Been Tested?

Checklist:

techno-disaster commented Aug 25, 2020

techno-disaster commented Sep 3, 2020

isabelcosta commented Sep 3, 2020

techno-disaster commented Sep 9, 2020

bartekpacia commented Sep 9, 2020

isabelcosta Sep 9, 2020

Choose a reason for hiding this comment

techno-disaster Sep 10, 2020

Choose a reason for hiding this comment

isabelcosta Sep 9, 2020

Choose a reason for hiding this comment

techno-disaster Sep 10, 2020

Choose a reason for hiding this comment

techno-disaster Sep 10, 2020

Choose a reason for hiding this comment

isabelcosta left a comment

Choose a reason for hiding this comment

isabelcosta commented Sep 9, 2020

techno-disaster commented Sep 10, 2020

techno-disaster commented Sep 13, 2020

robotjellyzone left a comment

Choose a reason for hiding this comment

techno-disaster commented Sep 17, 2020

techno-disaster commented Sep 17, 2020

robotjellyzone commented Sep 17, 2020 • edited Loading

techno-disaster commented Sep 17, 2020

robotjellyzone commented Sep 17, 2020 • edited Loading

techno-disaster commented Sep 20, 2020

techno-disaster commented Sep 20, 2020

techno-disaster commented Sep 22, 2020

techno-disaster commented Nov 17, 2020

isabelcosta commented Nov 19, 2020

robotjellyzone commented Sep 17, 2020 •

edited

Loading

robotjellyzone commented Sep 17, 2020 •

edited

Loading