-
Notifications
You must be signed in to change notification settings - Fork 58
Update dependencies #102
Update dependencies #102
Conversation
Won't it create non-deterministic builds? Also: commit squashing ;P |
I'm not sure what non-deterministic builds are ? |
I mean that the Flutter version we're using should be explicitly defined. PS After writing this, I'm not sure whether it is a good or bad idea. Non-deterministic builds are a problem on Android when you don't hardcode libraries version. This case is slightly similar but also slightly different. |
but if we have already asked contributors to work with the latest flutter beta branch (this is a check in issue template too) , won't the local machine flutter version and beta branch version be the same? Because basically beta channel is cloning the flutter repo and the beta branch.You can check this out here |
We can't assume this, because people often forget to |
Well in that case, even if we update our CI with hard-coded version number and the contributor hasn't updated it will be the same case right? for example flutter released v2 for beta, and we updated it on the CI, but the contributor forgot flutter upgrade, this will be the same case as you are saying right? Solution to this could be to just stick with a very old flutter beta build to be sure everyone is on that atleast, but that doesn't make any sense right? So what do you think, how should we handle this? |
Okay, I think we can try this and see if we'll encounter any problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@techno-disaster Since these were slight changes so, it Looks good to me 👍 but to check whether these changes are giving required result this needs testing to changing the label to Testing
Also, can you please resolve the merge conflicts? @techno-disaster
Thanks for solving the conflict @bartekpacia . Keeping bloc and flutter bloc on version 4.x.x because some changes are required for migrating to 5.x.x , Will do that separately in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested every other feature of the app, so, everything is working and nothing is breaking as expected as can be seen from the following gif :
great job @techno-disaster 👍
Just want to know is Find Members feature is not implemented yet ? or maybe I am not aware of it? @techno-disaster |
@robotjellyzone no, search is not implemented yet. But the find members button should take you to the members page when you don't have any prior relations. |
as you can see @techno-disaster in the provided gif that on clicking Find Members , its not taking anywhere? and it should as you say so, may be your pr is behind the parent repo 🤔 |
@robotjellyzone I just checked and this is due to the #108 PR ig, it changes how we do bottom navy. But the fix is not related to this PR. You can approve this and I will create a new issue for this :) |
Issue up #113 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok @techno-disaster i am approving so, that you can create a new issue for that find members issue :)
ffbe3e2
@anitab-org/mentorship-flutter-maintainers can you review this asap? |
@bartekpacia can you please review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Update dependencies and put
beta
in github action instead of hardcoding flutter versionFlutter Channel:
How has this been tested?
Logs with these changes can be found here
Type of Change:
Delete irrelevant options.