Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/core): theming validation for m2 themes firing incorrectly #28707

Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix(material/core): theming validation for m2 themes firing incorrectly #28707

merged 1 commit into from
Mar 11, 2024

Commits on Mar 8, 2024

  1. fix(material/core): theming validation for m2 themes firing incorrectly 

    Fixes that theming validation for M2 themes was firing incorrectly, because the validation code was going through the `get-color-config`, `get-density-config` and `get-typography-config` functions which in turn were reading the internalized version of the theme where all the values were the same. Since Sass maps are immutable, they were being compared based on their values and always considered as the same theme.
    @crisbeto
    crisbeto committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    7fa517d View commit details
    Browse the repository at this point in the history