fix(material/core): theming validation for m2 themes firing incorrectly #28707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes that theming validation for M2 themes was firing incorrectly, because the validation code was going through the `get-color-config`, `get-density-config` and `get-typography-config` functions which in turn were reading the internalized version of the theme where all the values were the same. Since Sass maps are immutable, they were being compared based on their values and always considered as the same theme.
andrewseguin
approved these changes
Mar 11, 2024
mmalerba
approved these changes
Mar 11, 2024
| $color-config: get-color-config($theme); | ||
| $density-config: get-density-config($theme); | ||
| $typography-config: get-typography-config($theme); | ||
| $color-config: map.get($theme, $_internals, m2-config, color) or get-color-config($theme); |
There was a problem hiding this comment.
you could expose this function internally if you want: https://github.com/angular/components/blob/main/src/material/core/theming/_m2-inspection.scss#L44, would probably make the logic here slightly simpler. Though this is fine too
crisbeto
added a commit
that referenced
this pull request
Mar 11, 2024
…ly (#28707) Fixes that theming validation for M2 themes was firing incorrectly, because the validation code was going through the `get-color-config`, `get-density-config` and `get-typography-config` functions which in turn were reading the internalized version of the theme where all the values were the same. Since Sass maps are immutable, they were being compared based on their values and always considered as the same theme. (cherry picked from commit e524567)
crisbeto
added a commit
that referenced
this pull request
Mar 11, 2024
…ly (#28707) Fixes that theming validation for M2 themes was firing incorrectly, because the validation code was going through the `get-color-config`, `get-density-config` and `get-typography-config` functions which in turn were reading the internalized version of the theme where all the values were the same. Since Sass maps are immutable, they were being compared based on their values and always considered as the same theme. (cherry picked from commit e524567)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that theming validation for M2 themes was firing incorrectly, because the validation code was going through the
get-color-config,get-density-configandget-typography-configfunctions which in turn were reading the internalized version of the theme where all the values were the same. Since Sass maps are immutable, they were being compared based on their values and always considered as the same theme.