Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update document bullet formatting #28054

Closed
wants to merge 5 commits into from
Closed

docs: update document bullet formatting #28054

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4c687f3
docs(angular/components): document bullet formatting incompatible
essjay05 Nov 3, 2023
991847c
docs: Update CODE_REVIEWS.md
essjay05 Nov 6, 2023
d178c6c
Merge branch 'angular:main' into docs-code-review-cleanup
essjay05 Nov 6, 2023
6093f72
Merge branch 'angular:main' into docs-code-review-cleanup
essjay05 Nov 9, 2023
b5cbaa6
Merge branch 'angular:main' into docs-code-review-cleanup
essjay05 Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions CODE_REVIEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,27 @@
# Code reviews for Angular Material

* Before any coding begins on new, large, or breaking work, a design discussion should take place.
* All code changes require a review and approval.
* All behaviors should be covered by unit tests in the same PR.
* Large changes should be accompanied by corresponding e2e tests in the same PR.
* Authors should attempt to keep PRs to 200 - 300 line changes.
- Before any coding begins on new, large, or breaking work, a design discussion should take place
- All code changes require a review and approval
- All behaviors should be covered by unit tests in the same PR
- Large changes should be accompanied by corresponding e2e tests in the same PR
- Authors should attempt to keep PRs to 200 - 300 line changes

## Workflow

1. The code author sends a PR for review. This request should include:
* A high-level description of the change being made.
* Links to any relevant issues.
* Screenshots (for visual changes or new additions)

- A high-level description of the change being made
- Links to any relevant issues
- Screenshots (for visual changes or new additions)

2. Reviews provide comments and the author responds / makes changes. Repeat until LGTM.
3. One or more of the reviewers approve the pull request.
4. Once the PR is approved, either the author or the reviewer can add the "merge-ready"
label to indicate that the PR is ready to be merged.
5. The party responsible for merging PRs will do so.

## How PRs are merged

The team has a weekly rotation for the "caretaker" who is responsible for merging PRs. Before being
merged, the caretaker runs PRs through Google's internal presubmit system. This process helps
greatly in keeping the library stable by running against the tests of many applications inside of
Expand Down
Loading