Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update document bullet formatting #28054

Closed
wants to merge 5 commits into from
Closed

docs: update document bullet formatting #28054

wants to merge 5 commits into from

Conversation

essjay05
Copy link
Contributor

@essjay05 essjay05 commented Nov 3, 2023

Update bulleted points in CODE_REVIEWS.md to remove '.' at the end of each point to be cohesive with CONTRIBUTING.md guidelines.

@essjay05
docs(angular/components): document bullet formatting incompatible
4c687f3 
Updated bulleted points in CODE_REVIEWS.md to remove '.' at the
end of each point to be cohesive with CONTRIBUTING.md guidelines.

:s
:q
:1
:!
@angular-robot angular-robot bot added the area: docs Related to the documentation label Nov 3, 2023
devversion
devversion approved these changes Nov 6, 2023
View reviewed changes
CODE_REVIEWS.md Outdated Show resolved Hide resolved
@crisbeto crisbeto removed the request for review from josephperrott November 9, 2023 04:56
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 9, 2023
@crisbeto crisbeto self-assigned this Nov 9, 2023
@crisbeto crisbeto added target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release labels Nov 9, 2023
@crisbeto
Copy link
Member

crisbeto commented Nov 9, 2023

@essjay05 can you rebase the PR? I just tried merging it and got some conflicts.

@crisbeto crisbeto added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Nov 9, 2023
@essjay05
Copy link
Contributor Author

essjay05 commented Nov 9, 2023

@essjay05 can you rebase the PR? I just tried merging it and got some conflicts.
@crisbeto Done! Let me know if you need anything else from my end.

@essjay05
Copy link
Contributor Author

New cleaned up PR to replace this one can be found here: #28123

@essjay05 essjay05 closed this Nov 14, 2023
@essjay05 essjay05 mentioned this pull request Nov 14, 2023
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@essjay05 @crisbeto @devversion