Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(material/dialog): MatDialog: change member _dialog (cdk) from private to protected (#28019) #28020

Merged
merged 1 commit into from
Oct 31, 2023
Merged

feat(material/dialog): MatDialog: change member _dialog (cdk) from private to protected (#28019) #28020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/material/dialog/dialog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export class MatDialog implements OnDestroy {
private readonly _openDialogsAtThisLevel: MatDialogRef<any>[] = [];
private readonly _afterAllClosedAtThisLevel = new Subject<void>();
private readonly _afterOpenedAtThisLevel = new Subject<MatDialogRef<any>>();
private _dialog: Dialog;
protected _dialog: Dialog;
protected dialogConfigClass = MatDialogConfig;

private readonly _dialogRefConstructor: Type<MatDialogRef<any>>;
Expand Down
3 changes: 3 additions & 0 deletions tools/public_api_guard/material/dialog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { ComponentFactoryResolver } from '@angular/core';
import { ComponentPortal } from '@angular/cdk/portal';
import { ComponentRef } from '@angular/core';
import { ComponentType } from '@angular/cdk/overlay';
import { Dialog } from '@angular/cdk/dialog';
import { DialogRef } from '@angular/cdk/dialog';
import { Direction } from '@angular/cdk/bidi';
import { ElementRef } from '@angular/core';
Expand Down Expand Up @@ -94,6 +95,8 @@ export class MatDialog implements OnDestroy {
get afterOpened(): Subject<MatDialogRef<any>>;
closeAll(): void;
// (undocumented)
protected _dialog: Dialog;
// (undocumented)
protected dialogConfigClass: typeof MatDialogConfig;
getDialogById(id: string): MatDialogRef<any> | undefined;
// (undocumented)
Expand Down
Loading