Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(material/dialog): MatDialog: change member _dialog (cdk) from private to protected (#28019) #28020

Merged

Conversation

dolezaljan
Copy link
Contributor

@dolezaljan dolezaljan commented Oct 29, 2023

Having customized MatDialog allow to have customized cdk/dialog inside of it.

c.f. #28019 for details

@google-cla
Copy link

google-cla bot commented Oct 29, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Oct 29, 2023
@dolezaljan dolezaljan force-pushed the mat-dialog-protected-cdk-dialog-member branch from fe0d98f to 1d77db9 Compare October 31, 2023 09:20
@dolezaljan dolezaljan changed the title feat(material/dialog:MatDialog): change cdk member _dialog from private to protected (#28019) feat(material/dialog): MatDialog: change member _dialog (cdk) from private to protected (#28019) Oct 31, 2023
…ivate to protected (angular#28019)

Having customized MatDialog allow to have customized cdk/dialog inside of it.
@dolezaljan dolezaljan force-pushed the mat-dialog-protected-cdk-dialog-member branch from 1d77db9 to 819cc46 Compare October 31, 2023 10:54
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: rc This PR is targeted for the next release-candidate labels Oct 31, 2023
@dolezaljan
Copy link
Contributor Author

ad merge: fix commit messge tag:

feat(material/dialog): change member _dialog (cdk) from private to protected (#28019)
    
Allow to have custom cdk/dialog as a member of custom MatDialog.
Example usage: scoped dialogs.
    
Closes #28019

I can push this one if desirable.

@crisbeto
Copy link
Member

It's okay, I'll reword it when merging in the PR.

@crisbeto crisbeto self-assigned this Oct 31, 2023
@crisbeto crisbeto added target: patch This PR is targeted for the next patch release and removed target: rc This PR is targeted for the next release-candidate labels Oct 31, 2023
@crisbeto crisbeto added target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels Oct 31, 2023
@crisbeto crisbeto merged commit 238e978 into angular:main Oct 31, 2023
26 of 29 checks passed
crisbeto pushed a commit that referenced this pull request Oct 31, 2023
…vate to protected (#28019) (#28020)

Having customized MatDialog allow to have customized cdk/dialog inside of it.

(cherry picked from commit 238e978)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants