-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(material/dialog): MatDialog: change member _dialog (cdk) from private to protected (#28019) #28020
feat(material/dialog): MatDialog: change member _dialog (cdk) from private to protected (#28019) #28020
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
fe0d98f
to
1d77db9
Compare
…ivate to protected (angular#28019) Having customized MatDialog allow to have customized cdk/dialog inside of it.
1d77db9
to
819cc46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ad
I can push this one if desirable. |
It's okay, I'll reword it when merging in the PR. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Having customized MatDialog allow to have customized cdk/dialog inside of it.
c.f. #28019 for details