Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove subscription for expandAll and collapseAll #27850

Merged
merged 1 commit into from
Oct 6, 2023
Merged

remove subscription for expandAll and collapseAll #27850

merged 1 commit into from
Oct 6, 2023

Commits on Oct 5, 2023

  1. fix(cdk-tree): fix crash in test cases with max call stack 

    Fix crash in test cases " An error was thrown in afterAll. RangeError: Maximum call stack size exceeded."

example: https://app.circleci.com/pipelines/github/angular/components/58166/workflows/cc9e4f5d-2182-44a5-89a6-56f93e196843/jobs/506030

Fix crash when happened in expandAll and collapseAll methods. Use direct
value of `_flattenedNodes` rather than subscribing to avoid unnecessary
subscription. Using the value directly is safe because `_flattenedNodes`
is a synchronous cache.
    @zarend
    zarend committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    442229d View commit details
    Browse the repository at this point in the history