Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove subscription for expandAll and collapseAll #27850

Merged
merged 1 commit into from
Oct 6, 2023
Merged

remove subscription for expandAll and collapseAll #27850

merged 1 commit into from
Oct 6, 2023

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Sep 26, 2023

No description provided.

@zarend zarend added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Sep 26, 2023
@zarend zarend force-pushed the cdk-tree-revamp-debug-expand-all-collapse-all branch from fdf203b to 06ce6a8 Compare September 27, 2023 17:30
@zarend zarend marked this pull request as ready for review September 27, 2023 17:45
@zarend zarend force-pushed the cdk-tree-revamp branch 4 times, most recently from f567a4f to b9a847f Compare October 4, 2023 20:54
@devversion devversion removed their request for review October 5, 2023 09:50
@zarend
fix(cdk-tree): fix crash in test cases with max call stack
442229d 
Fix crash in test cases " An error was thrown in afterAll. RangeError: Maximum call stack size exceeded."

example: https://app.circleci.com/pipelines/github/angular/components/58166/workflows/cc9e4f5d-2182-44a5-89a6-56f93e196843/jobs/506030

Fix crash when happened in expandAll and collapseAll methods. Use direct
value of `_flattenedNodes` rather than subscribing to avoid unnecessary
subscription. Using the value directly is safe because `_flattenedNodes`
is a synchronous cache.
@zarend zarend force-pushed the cdk-tree-revamp-debug-expand-all-collapse-all branch from 06ce6a8 to 442229d Compare October 5, 2023 22:55
@zarend zarend merged commit 7784054 into angular:cdk-tree-revamp Oct 6, 2023
16 of 21 checks passed
@zarend zarend deleted the cdk-tree-revamp-debug-expand-all-collapse-all branch October 6, 2023 16:42
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BobobUnicorn BobobUnicorn Awaiting requested review from BobobUnicorn

@jelbourn jelbourn Awaiting requested review from jelbourn jelbourn is a code owner

@andrewseguin andrewseguin Awaiting requested review from andrewseguin andrewseguin is a code owner

Assignees
No one assigned
Labels
area: cdk/tree dev-app preview When applied, previews of the dev-app are deployed to Firebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zarend