-
Notifications
You must be signed in to change notification settings - Fork 347
Add code snippets for support-connected-displays.md #843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
66 changes: 66 additions & 0 deletions
66
...ts/src/main/java/com/example/compose/snippets/adaptivelayouts/SupportConnectedDisplays.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| /* | ||
| * Copyright 2026 The Android Open Source Project | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.example.compose.snippets.adaptivelayouts | ||
|
|
||
| import android.app.ActivityOptions | ||
| import android.content.Context | ||
| import android.content.Intent | ||
| import android.hardware.display.DisplayManager | ||
| import android.os.Build | ||
| import android.os.Bundle | ||
| import android.view.Display | ||
| import androidx.activity.ComponentActivity | ||
|
|
||
| class SupportConnectedDisplays : ComponentActivity() { | ||
|
|
||
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
| } | ||
|
|
||
| private fun getDisplayInfoSnippet() { | ||
| // [START android_compose_layouts_connected_displays_get_info] | ||
| val displayManager = getSystemService(Context.DISPLAY_SERVICE) as DisplayManager | ||
| val displays = displayManager.getDisplays() | ||
| // The default display is 0. External displays have other IDs. | ||
| val externalDisplays = displays.filter { it.displayId != Display.DEFAULT_DISPLAY } | ||
| // [END android_compose_layouts_connected_displays_get_info] | ||
| } | ||
|
|
||
| private fun launchActivitySnippet() { | ||
| // [START android_compose_layouts_connected_displays_launch_activity] | ||
| // Get DisplayManager and find the first external display. | ||
| val displayManager = getSystemService(Context.DISPLAY_SERVICE) as DisplayManager | ||
| val externalDisplayId = displayManager.displays | ||
| .firstOrNull { it.displayId != Display.DEFAULT_DISPLAY } | ||
| ?.displayId | ||
|
|
||
| // If an external display is found, launch the activity on it. | ||
| if (externalDisplayId != null) { | ||
| val intent = Intent(this, MySecondaryActivity::class.java) | ||
| val options = ActivityOptions.makeBasic() | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) { | ||
| options.launchDisplayId = externalDisplayId | ||
| } | ||
| startActivity(intent, options.toBundle()) | ||
| } else { | ||
| // Optionally, handle the case where no external display is connected. | ||
| } | ||
| // [END android_compose_layouts_connected_displays_launch_activity] | ||
| } | ||
| } | ||
|
|
||
| class MySecondaryActivity : ComponentActivity() | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current implementation will launch the activity on the default display for Android versions below Oreo (API 26), even when an external display is found. This can be misleading for a code snippet that demonstrates launching an activity on a connected display. To make the example clearer and avoid this behavior, the activity should only be launched if the API level is sufficient. Moving the
startActivitycall and related initializations inside the version check will ensure the activity is only launched on an external display when supported.