Skip to content

Add code snippets for support-connected-displays.md#843

Merged
kkuan2011 merged 3 commits intomainfrom
katherinekuan/support-connected-displays
Mar 19, 2026
Merged

Add code snippets for support-connected-displays.md#843
kkuan2011 merged 3 commits intomainfrom
katherinekuan/support-connected-displays

Conversation

@kkuan2011
Copy link
Contributor

Code snippets are for:

No snippets left hardcoded on the page.

@snippet-bot
Copy link

snippet-bot bot commented Mar 18, 2026

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces new code examples to enhance the documentation for supporting connected displays within Android Compose adaptive layouts. The goal is to provide practical, runnable code snippets that demonstrate how to retrieve display information and launch activities on external displays, thereby improving the clarity and utility of the related developer guide by replacing any hardcoded examples.

Highlights

  • New Code Snippets Added: Added new code snippets for the support-connected-displays.md documentation page, specifically for the URL https://developer.android.com/develop/ui/compose/layouts/adaptive/support-connected-displays. These snippets provide examples for retrieving display information and launching activities on external displays.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds code snippets for supporting connected displays. The implementation is mostly correct, but I found a potential issue in the launchActivitySnippet where the behavior on older Android versions could be misleading. I've provided a suggestion to improve the clarity and correctness of the snippet.

Comment on lines +53 to +58
val intent = Intent(this, MySecondaryActivity::class.java)
val options = ActivityOptions.makeBasic()
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
options.launchDisplayId = externalDisplayId
}
startActivity(intent, options.toBundle())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The current implementation will launch the activity on the default display for Android versions below Oreo (API 26), even when an external display is found. This can be misleading for a code snippet that demonstrates launching an activity on a connected display. To make the example clearer and avoid this behavior, the activity should only be launched if the API level is sufficient. Moving the startActivity call and related initializations inside the version check will ensure the activity is only launched on an external display when supported.

Suggested change
val intent = Intent(this, MySecondaryActivity::class.java)
val options = ActivityOptions.makeBasic()
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
options.launchDisplayId = externalDisplayId
}
startActivity(intent, options.toBundle())
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
val intent = Intent(this, MySecondaryActivity::class.java)
val options = ActivityOptions.makeBasic()
options.launchDisplayId = externalDisplayId
startActivity(intent, options.toBundle())
}

@kkuan2011 kkuan2011 requested a review from telpirion March 19, 2026 19:40
@kkuan2011 kkuan2011 merged commit 4e48e2c into main Mar 19, 2026
5 checks passed
@kkuan2011 kkuan2011 deleted the katherinekuan/support-connected-displays branch March 19, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants