Skip to content

Mlykotom/test skie update #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

Mlykotom/test skie update #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7aa1ddb
Switch plugins repository order to pick up skie
mlykotom Jun 11, 2025
d00e95f
Add explicit skie
mlykotom Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Fruitties/settings.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ enableFeaturePreview("TYPESAFE_PROJECT_ACCESSORS")
pluginManagement {
repositories {
google()
gradlePluginPortal()
mavenCentral()
gradlePluginPortal()
Comment on lines 20 to +21
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The order of repositories in pluginManagement has been changed. gradlePluginPortal() is typically listed with higher precedence than mavenCentral() for resolving Gradle plugins, as it's their primary distribution channel.

Was there a specific reason for placing mavenCentral() before gradlePluginPortal() here? If not, consider restoring the previous order (i.e., gradlePluginPortal() before mavenCentral(), after google()) for potentially more idiomatic and efficient plugin discovery.

        gradlePluginPortal()
        mavenCentral()

}
}

Expand Down
19 changes: 12 additions & 7 deletions renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,23 @@
"extends": [
"local>android/.github:renovate-config"
],

"baseBranches": [
"main"
],
"packageRules": [
{
"groupName": "Kotlin Dependencies",
"matchPackagePrefixes": [
"org.jetbrains.kotlin",
"co.touchlab.skie",
"com.google.devtools.ksp"
]
}
"matchPackagePrefixes": [
"org.jetbrains.kotlin",
"com.google.devtools.ksp"
]
},
{
"matchPackageNames": [
"co.touchlab.skie:co.touchlab.skie.gradle.plugin"
],
"groupName": "SKIE Update Only",
"prerelease": true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This prerelease: true configuration will enable Renovate to create pull requests for SKIE pre-release versions (e.g., alpha, beta, release candidates). This can be beneficial for early testing of new SKIE features or fixes.

Could you confirm this is the intended behavior? It's important for the team to be aware that these versions might be less stable than general availability releases and may require more thorough testing.

}
]
}
Loading