Skip to content

Mlykotom/test skie update #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

Mlykotom/test skie update #65

merged 2 commits into from
Jun 11, 2025

Conversation

mlykotom
Copy link
Collaborator

No description provided.

@mlykotom mlykotom merged commit a8dc563 into main Jun 11, 2025
3 checks passed
@mlykotom mlykotom deleted the mlykotom/test-skie-update branch June 11, 2025 10:26
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @mlykotom, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on refining the project's dependency management setup, specifically configuring Renovate to manage SKIE updates separately and include prereleases. It also includes a minor adjustment to the order of Gradle plugin repositories.

Highlights

  • Renovate Configuration: Updated the renovate.json file to modify how SKIE dependency updates are handled. SKIE is now removed from the general 'Kotlin Dependencies' group and has its own dedicated rule ('SKIE Update Only') which allows for prerelease versions.
  • Gradle Repository Order: Adjusted the order of repositories within the pluginManagement block in settings.gradle.kts, moving gradlePluginPortal() after mavenCentral().
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the Gradle plugin repository order in settings.gradle.kts and updates the Renovate configuration in renovate.json. The Renovate change separates SKIE dependency updates into a new rule and enables tracking of its pre-release versions.

My review includes:

  • A suggestion to reconsider the repository order in settings.gradle.kts to align with common practices for Gradle plugin resolution.
  • A point of awareness regarding the prerelease: true setting for SKIE in renovate.json, to ensure the implications of updating to potentially unstable versions are understood and intended.

Comment on lines 20 to +21
mavenCentral()
gradlePluginPortal()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The order of repositories in pluginManagement has been changed. gradlePluginPortal() is typically listed with higher precedence than mavenCentral() for resolving Gradle plugins, as it's their primary distribution channel.

Was there a specific reason for placing mavenCentral() before gradlePluginPortal() here? If not, consider restoring the previous order (i.e., gradlePluginPortal() before mavenCentral(), after google()) for potentially more idiomatic and efficient plugin discovery.

        gradlePluginPortal()
        mavenCentral()

"co.touchlab.skie:co.touchlab.skie.gradle.plugin"
],
"groupName": "SKIE Update Only",
"prerelease": true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This prerelease: true configuration will enable Renovate to create pull requests for SKIE pre-release versions (e.g., alpha, beta, release candidates). This can be beneficial for early testing of new SKIE features or fixes.

Could you confirm this is the intended behavior? It's important for the team to be aware that these versions might be less stable than general availability releases and may require more thorough testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant