Skip to content
This repository was archived by the owner on May 6, 2020. It is now read-only.

Conversation

@ithinkihaveacat
Copy link
Collaborator

@ithinkihaveacat ithinkihaveacat commented Aug 15, 2018

This has the same changes as #46, just rebased on top of master.

This will hopefully: (a) make the diff cleaner; (b) resolve conflicts; and (b) shut googlebot up.

jeffjose and others added 6 commits August 15, 2018 08:19
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@ithinkihaveacat
Copy link
Collaborator Author

@googlebot CLAs are approved for commit authors @jeffjose ([email protected]) and @philkrie ([email protected]); see discussion in #46.

@jeffjose and @philkire: can you confirm that this PR is what you are expecting?

@jeffjose
Copy link
Contributor

LGTM. Please wait for @philkrie to confirm his changes before merging. Thanks!

@philkrie
Copy link
Contributor

philkrie commented Aug 15, 2018

Looks good to me. @jeffjose: Should we merge now or wait to add the full update to use the latest Wappalyzer JSON?

@jeffjose
Copy link
Contributor

jeffjose commented Sep 3, 2019

This PR is now obsolete. We moved readiness-tool from this repo onto ampproject/amp-readiness.

Please feel free to close this PR out WITHOUT merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants