Adding Bing Ads + branch.io icon #46
Conversation
Visual refresh and performance improvements to AMP Readiness Tool
AMPBench is using the old Google Cache URL format. It should use the new format ampproject#29 ampproject#29 https://developers.google.com/amp/cache/overview https://ampbyexample.com/advanced/using_the_google_amp_cache/
Implement fix for issue AMPBench warns about missing ETag and informs about presence of ETag ampproject#37
Valid characters like ```á``` where failing while validating the canonicalURL
Fixes an issue when consuming the API with url that contains accented characters.
…eAmpLinks Adding warning when multiple amphtml links found in canonical page
Fix validation in entry point for urls that contains accented characters
|
LGTM |
…i (needs more testing), Wordpress (Wappalyzer regex), and Adobe Experience Manager (Wappalyzer regex). Still uses legacy Wappalyzer JSON formatting.
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
Didn't know to set the correct author email so CLA check broke... what's the best way to change author from "Phillip Kriegel <[email protected]>" to "Phillip Kriegel <[email protected]>"? |
|
@philkrie So, after some git research and experimentation, I can't find any approach better than essentially re-doing this pull request… @jeffjose do you mind if your authorship gets lost? If not, then @philkrie can you squash and force push (or create a fresh PR with the same content)? To preserve authorship I think you'll need to do the same commits again, in the same order. (I'm sure there is some way to fix this properly, but I don't know it. I did find https://help.github.com/articles/changing-author-info/ but that seems to create (some) changes to the repo even when no email addresses need to change, so I don't really trust it…) |
|
Sounds good, I've gone ahead and fixed the issue in my fork, and submit a PR to @jeffjose 's fork again. |
|
CLAs look good, thanks! |
Updated to support CMS
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
The commits are from authors who have already participated in this repo. We should be good to go here. Let me know if that is not the case. |
|
If I understand correctly we just need review and for the cla: yes label to be set to get around googlebot's warning. |
|
@ithinkihaveacat do you know how to proceed from here? As I see it, there's 2 issues. Google CLA and some merge conflicts. The latter should be pretty straightforward, but not sure what to do with the former. |
|
See #58 for the attempt to fix this PR. |
8 participants
Add Bings Ads detection rules + branch.io icon + version bump.
This also fixes LICENSE issue (see ampproject/amphtml#16272)