-
-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SfM Expanding application #1718
Conversation
a85d634
to
0f23520
Compare
56fb14e
to
2800d71
Compare
{ | ||
Eigen::JacobiSVD<Mat3> USV(E, Eigen::ComputeFullU | Eigen::ComputeFullV); | ||
Mat3 U = USV.matrixU(); | ||
// Vec3 d = USV.singularValues(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To remove if unused
sfm::ExpansionProcess::uptr expansionProcess = std::make_unique<sfm::ExpansionProcess>(); | ||
expansionProcess->setExpansionHistoryHandler(expansionHistory); | ||
expansionProcess->setExpansionIterationHandler(expansionIteration); | ||
/*expansionProcess->setExpansionIterationPostProcessHandler(expansionPostProcess);*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To remove if unused
/*sfm::ExpansionPostProcess::uptr expansionPostProcess; | ||
if (useRigConstraint) | ||
{ | ||
sfm::ExpansionPostProcessRig::uptr expansionPostProcessTyped = std::make_unique<sfm::ExpansionPostProcessRig>(); | ||
expansionPostProcessTyped->setMinimalNumberCameras(minNbCamerasForRigCalibration); | ||
expansionPostProcess = std::move(expansionPostProcessTyped); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To remove if unused
@@ -385,8 +331,8 @@ int aliceVision_main(int argc, char** argv) | |||
bestUsedTracks = usedTracks; | |||
} | |||
} | |||
|
|||
if (!buildSfmData(sfmData, bestPair, mapTracks, bestUsedTracks)) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing whitespace
@@ -0,0 +1,92 @@ | |||
// This file is part of the AliceVision project. | |||
// Copyright (c) 2023 AliceVision contributors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2024
@@ -0,0 +1,180 @@ | |||
// This file is part of the AliceVision project. | |||
// Copyright (c) 2023 AliceVision contributors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2024
@@ -0,0 +1,86 @@ | |||
// This file is part of the AliceVision project. | |||
// Copyright (c) 2023 AliceVision contributors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2024
@@ -0,0 +1,199 @@ | |||
// This file is part of the AliceVision project. | |||
// Copyright (c) 2023 AliceVision contributors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2024
@@ -0,0 +1,228 @@ | |||
// This file is part of the AliceVision project. | |||
// Copyright (c) 2023 AliceVision contributors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2024
@@ -0,0 +1,221 @@ | |||
// This file is part of the AliceVision project. | |||
// Copyright (c) 2023 AliceVision contributors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2024
New application for sfm expansion using an initial sfm solve (E.g. using sfmBootstrapping)
New objects for policies :
More modular approach to SFM to be able to change it's behavior more easily.
Extracted the various steps in different classes for better readability