Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C# implementation for the approximate counting algorithm #865

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stormofice
Copy link
Contributor

How to run this is described in #846.

@leios leios requested a review from june128 September 15, 2021 17:12
@leios leios added the lang: c# C# programming language label Sep 15, 2021
Copy link
Contributor

@henrikac henrikac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the fact that there has been added documentation to each method but I'm wondering why XML docstrings wasn't used?

More examples of how to make these docstrings.

@Amaras Amaras added the Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) label Oct 19, 2021
@stormofice
Copy link
Contributor Author

Hi, thanks for the review.

I didn't use docstrings originally, as there was some discussion on whether we should use language specific documentation style comments at all, but I agree that it looks way better and it makes sense here imo.

I also updated the error thresholds according to #901 and the output as per #913.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) lang: c# C# programming language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants