Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #48
This PR
sais
module undersuffix_array
modulesais()
function tobuild_suffix_array
for better code readability.This part mentioned in #48 has not been addressed in this PR yet. If we move
count_chars
andget_bucket_start_pos
tocharacters
module, a circular dependency occurs:characters
module depends onconverter
module, ascount_chars
requiresConverter
.converter
module depends oncharacter
module, asConverter
requiresCharacter
.While this might be handled by Rust language well, it'd be better to avoid this kind of complexity if possible. One option is to reorganize
character
module like below.character
Character
character::count
count_chars
,get_bucket_start_pos
character::Character
character::converter
Converter
character::Character
Anyway, let me postpone relocating
count_charts
andget_bucket_start_pos
for now.