You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's not obvious for readers that the module and function name sais computes a suffix array. Maybe it should be something like suffix_array instead.
Also, some functions in sais module like count_chars and get_bucket_start_pos are not specific to SA-IS algorithm nor suffix array. FMIndex::createuses these functions to build cs, but this misleads readers that the cs structure construction is related to SA-IS. Maybe these functions should reside in characters.rs or another module.
The text was updated successfully, but these errors were encountered:
It's not obvious for readers that the module and function name
sais
computes a suffix array. Maybe it should be something likesuffix_array
instead.Also, some functions in
sais
module likecount_chars
andget_bucket_start_pos
are not specific to SA-IS algorithm nor suffix array.FMIndex::create
uses these functions to buildcs
, but this misleads readers that thecs
structure construction is related to SA-IS. Maybe these functions should reside incharacters.rs
or another module.The text was updated successfully, but these errors were encountered: