Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #48, I proposed moving
sais
module tosuffix_array
.However,
suffix_array
module already exists and consists of the following elements.HasPosition
)sample
,SuffixOrderSampledArray
)It's not so nice to colocate SA-IS related methods in
suffix_array
with these elements. Therefore, this PR moves the existingsuffix_array
module elements to different locations beforehand.HasPosition
) will be moved toiter
module, where other traits for search index (FMIndexBackend
,HeapSize
) exist. We may also want to consider restructuring theiter
module, but this can be done in another work.sample
,SuffixOrderSampledArray
) will be moved to a new modulesuffix_array::sample
. This is not exposed to crate users.After that, we can move
sais
module tosuffix_array::sais
.