Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: config aws s3 sdk to avoid connection closed error 2 #50995

Conversation

tryangul
Copy link
Contributor

@tryangul tryangul commented Jan 9, 2025

Same as other PR but avoids vercel issue.

What

Configures the okhttp client wrapper inside the s3 client to poll for idle connections

Why

We have seen a lot of transient errors due to closed connections and this is the maintainer sanctioned way of alleviating these issues.

See this gh thread for background.

We may switch to a different workaround if this doesn't reduce failures appreciably.

@tryangul tryangul requested a review from a team as a code owner January 9, 2025 00:11
Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 0:16am

@tryangul tryangul changed the title Rbroughan/config aws s3 sdk to avoid connection closed error 2 chore: config aws s3 sdk to avoid connection closed error 2 Jan 9, 2025
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Jan 9, 2025
@tryangul tryangul requested a review from benmoriceau January 9, 2025 00:19
@tryangul tryangul merged commit 1061780 into master Jan 9, 2025
26 checks passed
@tryangul tryangul deleted the rbroughan/config-aws-s3-sdk-to-avoid-connection-closed-error-2 branch January 9, 2025 00:26
tryangul added a commit that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants