chore: config aws s3 sdk to avoid connection closed error #50993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
This reverts commit c6f381d.
|
/format-fix
|
benmoriceau
approved these changes
Jan 9, 2025
|
Closing in favor of #50995 since it doesn't hit vercel issues |
tryangul
deleted the
rbroughan/config-aws-s3-sdk-to-avoid-connection-closed-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Configures the okhttp client wrapper inside the s3 client to poll for idle connections
Why
We have seen a lot of transient errors due to closed connections and this is the maintainer sanctioned way of alleviating these issues.
See this gh thread for background.
We may switch to a different workaround if this doesn't reduce failures appreciably.