Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix failing airbyte-ci-install (related to ubuntu-latest image no longer compatible with airbyte-ci binaries) #50992

Merged
merged 10 commits into from
Jan 8, 2025
34 changes: 22 additions & 12 deletions .github/actions/install-airbyte-ci/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,21 +30,26 @@ runs:
- name: "Determine how Airbyte CI should be installed"
shell: bash
id: determine-install-mode
run:
echo "install-mode=source" >> $GITHUB_OUTPUT
echo "SENTRY_ENVIRONMENT=dev" >> $GITHUB_ENV

# When the PR is from a fork, we always install from binary
if: inputs.is_fork == 'false'
run: |
if [[ "${{ github.ref }}" != "refs/heads/master" ]] && [[ "${{ steps.changes.outputs.pipelines_any_changed }}" == "true" ]]; then
echo "Making changes to Airbyte CI on a non-master branch. Airbyte-CI will be installed from source."
echo "install-mode=source" >> $GITHUB_OUTPUT
echo "SENTRY_ENVIRONMENT=dev" >> $GITHUB_ENV
else
echo "install-mode=binary" >> $GITHUB_OUTPUT
echo "SENTRY_ENVIRONMENT=production" >> $GITHUB_ENV
fi
# if: inputs.is_fork == 'false'
# run: |
# if [[ "${{ github.ref }}" != "refs/heads/master" ]] && [[ "${{ steps.changes.outputs.pipelines_any_changed }}" == "true" ]]; then
# echo "Making changes to Airbyte CI on a non-master branch. Airbyte-CI will be installed from source."
# echo "install-mode=source" >> $GITHUB_OUTPUT
# echo "SENTRY_ENVIRONMENT=dev" >> $GITHUB_ENV
# else
# echo "install-mode=binary" >> $GITHUB_OUTPUT
# echo "SENTRY_ENVIRONMENT=production" >> $GITHUB_ENV
# fi

- name: Install Airbyte CI from binary
id: install-airbyte-ci-binary
if: steps.determine-install-mode.outputs.install-mode == 'binary' || ${{ inputs.is_fork }} == 'true'
if: false
# if: steps.determine-install-mode.outputs.install-mode == 'binary' || ${{ inputs.is_fork }} == 'true'
shell: bash
run: |
curl -sSL ${{ inputs.airbyte_ci_binary_url }} --output airbyte-ci-bin
Expand All @@ -54,7 +59,7 @@ runs:
- name: Install Python 3.10
id: install-python-3-10
uses: actions/setup-python@v4
if: steps.determine-install-mode.outputs.install-mode == 'source'
# if: steps.determine-install-mode.outputs.install-mode == 'source'
with:
python-version: "3.10"
token: ${{ inputs.github_token }}
Expand All @@ -69,6 +74,11 @@ runs:
pipx ensurepath
pipx install ${{ inputs.path_to_airbyte_ci_source }}

- name: Print installed `airbyte-ci` version
shell: bash
run: |
airbyte-ci --version

- name: Get dagger engine image name
id: get-dagger-engine-image-name
shell: bash
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/connectors_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:
# If the condition is not met the job will be skipped (it will not fail)
if: (github.event_name == 'pull_request' && needs.changes.outputs.connectors == 'true' && github.event.pull_request.head.repo.fork != true) || github.event_name == 'workflow_dispatch'
name: Connectors CI
runs-on: connector-test-large
runs-on: linux-20.04-large # Custom runner, defined in GitHub org settings
aaronsteers marked this conversation as resolved.
Show resolved Hide resolved
timeout-minutes: 360 # 6 hours
steps:
- name: Checkout Airbyte
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/connectors_version_increment_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ on:
jobs:
connectors_ci:
name: Connectors Version Increment Check
runs-on: connector-test-large
runs-on: linux-20.04-large # Custom runner, defined in GitHub org settings
aaronsteers marked this conversation as resolved.
Show resolved Hide resolved
if: github.event.pull_request.head.repo.fork != true
timeout-minutes: 22
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/gradle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
# Any revision upwards should be based on a performance analysis of gradle scans.
# See https://github.com/airbytehq/airbyte/pull/36055 for an example of this,
# which explains why which we went down from 64 cores to 16.
runs-on: connector-test-large
runs-on: linux-20.04-large # Custom runner, defined in GitHub org settings
aaronsteers marked this conversation as resolved.
Show resolved Hide resolved
name: Gradle Check
timeout-minutes: 30
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/live_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ on:
jobs:
live_tests:
name: Live Tests
runs-on: connector-test-large
runs-on: linux-20.04-large # Custom runner, defined in GitHub org settings
aaronsteers marked this conversation as resolved.
Show resolved Hide resolved
timeout-minutes: 360 # 6 hours
steps:
- name: Checkout Airbyte
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-bulk-cdk.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ env:
jobs:
publish-bulk-cdk:
name: Publish Bulk CDK
runs-on: connector-test-large
runs-on: linux-20.04-large # Custom runner, defined in GitHub org settings
aaronsteers marked this conversation as resolved.
Show resolved Hide resolved
timeout-minutes: 30
steps:
- name: Checkout Airbyte
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-java-cdk-command.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ env:
jobs:
publish-cdk:
name: Publish Java CDK
runs-on: connector-test-large
runs-on: linux-20.04-large # Custom runner, defined in GitHub org settings
aaronsteers marked this conversation as resolved.
Show resolved Hide resolved
timeout-minutes: 30
steps:
- name: Link comment to Workflow Run
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/regression_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ on:
jobs:
regression_tests:
name: Regression Tests
runs-on: connector-test-large
runs-on: linux-20.04-large # Custom runner, defined in GitHub org settings
aaronsteers marked this conversation as resolved.
Show resolved Hide resolved
timeout-minutes: 360 # 6 hours
steps:
- name: Checkout Airbyte
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
{
"todo-stream-name": {
"todo-field-name": "todo-abnormal-value"
},
"fake-stream-name": {
"fake-field": "fake-value"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 6371b14b-bc68-4236-bfbd-468e8df8e968
dockerImageTag: 0.3.7
dockerImageTag: 0.3.8
dockerRepository: airbyte/source-pokeapi
githubIssueLabel: source-pokeapi
icon: pokeapi.svg
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/pokeapi.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ The PokéAPI uses the same [JSONSchema](https://json-schema.org/understanding-js

| Version | Date | Pull Request | Subject |
| :------ | :--------- | :------------------------------------------------------- | :---------------------------------------------- |
| 0.3.8 | 2025-01-08 | []() | Fake update |
| 0.3.7 | 2024-12-28 | [50708](https://github.com/airbytehq/airbyte/pull/50708) | Update dependencies |
| 0.3.6 | 2024-12-21 | [50261](https://github.com/airbytehq/airbyte/pull/50261) | Update dependencies |
| 0.3.5 | 2024-12-14 | [49689](https://github.com/airbytehq/airbyte/pull/49689) | Update dependencies |
Expand Down
Loading