-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧪🚑 Fix coverage.py-included paths @ XML #1074
🧪🚑 Fix coverage.py-included paths @ XML #1074
Conversation
This patch fixes the directory misattribution of test file paths by marking the entire repository directory as source.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1074 +/- ##
===========================================
+ Coverage 62.40% 92.89% +30.49%
===========================================
Files 38 26 -12
Lines 6626 4295 -2331
Branches 356 356
===========================================
- Hits 4135 3990 -145
+ Misses 2464 279 -2185
+ Partials 27 26 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. This is less invasive than the alternative #1071
We are still getting misses for multi-line coverage but its much better that we can see whats covered now 👍 |
@bdraco multiline? do you mean branches? |
Statements that span more than one line. |
Ie
|
@bdraco that shows up as covered for me.. |
@bdraco oh... I see what you're talking about! That's not related to coverage.py. It excludes those lines (so they aren't marked as covered or uncovered). However, we also upload coverage reports generated by MyPy and it explicitly marks the lines you're referring to as uncovered. The fix should be done in the context of MyPy, not pytest. |
One way to spot this would be toggling the flags on the UI. For example, if you go to Codecov and select a flag only reported from pytest jobs (like Meanwhile, I've added a |
This patch fixes the directory misattribution of test file paths by marking the entire repository directory as source.
fixes #1026 (comment)
closes #1029
closes #1071
ref https://github.com/orgs/aio-libs/discussions/36