Attempt to fix coverage report #1071
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1071 +/- ##
===========================================
+ Coverage 62.40% 92.89% +30.49%
===========================================
Files 38 26 -12
Lines 6626 4295 -2331
Branches 356 356
===========================================
- Hits 4135 3990 -145
+ Misses 2464 279 -2185
+ Partials 27 26 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@bdraco during previous debugging sessions I established that it's fault of the Codecov action v4 and v3 works just fine. Coverage.py is configured correctly but Codecov misinterprets the file paths for the reports made by pytest (but not those produced by MyPy). |
|
Anyway, I've been meaning to compose a bug report for Codecov but need to find old experimental PRs and comments where I documented the difference exactly. Perhaps, you'll add your own discoveries to that. |
pytest.ini
Outdated
| @@ -23,9 +23,9 @@ addopts = | |||
| -p pytest_cov | |||
|
|
|||
| # `pytest-cov`: | |||
| --cov | |||
There was a problem hiding this comment.
FTR, pytest-cov usually behaves more correctly with this setting and most of the config happening in coverage.py. Besides, the idea is that if any other tools use coverage.py directly, they'd be able to rely on the same config. This is the principle I apply to all the integrated tooling.
I'd like this pattern to remain in place.
There was a problem hiding this comment.
I'm going to revert all the unneeded changes once I get things working (well.. if I get things working)
There was a problem hiding this comment.
Okay. Just postpone merging until my final review. I synchronize the configs to have the same shape across repos, so I want to make sure the end result fits within the structure I got for that.
There was a problem hiding this comment.
Unfortunately I can't get it to work without this change
Everything else I've attempted changes the package back to "." in coverage.xml
There was a problem hiding this comment.
I've gone so far as to dump the internal coverage options and make sure they are the same and it still changes it back to "."
There was a problem hiding this comment.
If what you're saying is correct, we should probably tell Ned about the bug...
There was a problem hiding this comment.
I'm going to bed now, but feel free to merge it if you think that it is a proper fix.
There was a problem hiding this comment.
Just saw your comment as I was deep in debugging. 🤦
No description provided.