Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sharing instructions and policy refresh #1784

Merged
merged 62 commits into from
Aug 18, 2021
Merged

Conversation

jacobdadams
Copy link
Member

Ok, after much rebasing and re-editing here's a fresh look at the reworked sharing and policy pages as part of agrc/porter#87.

Goals:

  • Guide first-time and veteran contributors alike through the sharing process.
  • Establish clear data lifecycle policies for how and why we do things.
  • Continue to clarify the interactions between the different parts of the SGID.
  • Lay the policy foundation for a proper db(s) for metadata and stewardship info (Change stewardship tab to proper DB porter#92)

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2021

Images automagically compressed by Calibre's image-actions

Compression reduced images by 24.3%, saving 15.05 KB.

Filename Before After Improvement Visual comparison
images/SGIDSharing.png 61.83 KB 46.78 KB -24.3% View diff

901 images did not require optimisation.

@netlify
Copy link

netlify bot commented Jul 8, 2021

✔️ Deploy Preview for gis-utah-gov ready!

🔨 Explore the source changes: ad1d396

🔍 Inspect the deploy log: https://app.netlify.com/sites/gis-utah-gov/deploys/60e764c1fb1e7d00078d1022

😎 Browse the preview: https://deploy-preview-1784--gis-utah-gov.netlify.app

@netlify
Copy link

netlify bot commented Jul 8, 2021

✔️ Deploy Preview for gis-utah-gov ready!

🔨 Explore the source changes: c27efb2

🔍 Inspect the deploy log: https://app.netlify.com/sites/gis-utah-gov/deploys/611d829ed5fec30007259f23

😎 Browse the preview: https://deploy-preview-1784--gis-utah-gov.netlify.app

Copy link
Member

@steveoh steveoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. I'm excited to get this out there. I think once the question is answered we are good to go unless anyone else has concerns.

about/policy/index.md Outdated Show resolved Hide resolved
@steveoh steveoh enabled auto-merge (rebase) July 27, 2021 22:53
@steveoh steveoh disabled auto-merge July 27, 2021 22:58
sharing/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@nathankota nathankota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some mostly benign comments and questions, but serious thanks and praises for your assessment of all the SGID parts, pieces, policies, guidelines and your preparation of PR's.

image

@steveoh
Copy link
Member

steveoh commented Aug 17, 2021

Is this week a good target to merge?

@jacobdadams
Copy link
Member Author

jacobdadams commented Aug 17, 2021 via email

Copy link
Member Author

@jacobdadams jacobdadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok @steveoh , one last question before we merge. Months ago I did a quick-and-dirty addition of the "Sharing" tab to the top navigation right after "Developer." Are there additional things we need to do to make that cleaner/more persistent (I'm remembering something about the colors underneath the "active" tab?) or should I just strip that for now and find somewhere else to link the sharing/ page from?

about/policy/metadata/index.md Show resolved Hide resolved
sharing/metadata/index.md Show resolved Hide resolved
sharing/open-sgid/index.md Show resolved Hide resolved
@steveoh
Copy link
Member

steveoh commented Aug 18, 2021

Ok @steveoh , one last question before we merge. Months ago I did a quick-and-dirty addition of the "Sharing" tab to the top navigation right after "Developer." Are there additional things we need to do to make that cleaner/more persistent (I'm remembering something about the colors underneath the "active" tab?) or should I just strip that for now and find somewhere else to link the sharing/ page from?

Let's strip it and put it somewhere else. The nav has mobile issues already and this addition makes it worse.

@jacobdadams
Copy link
Member Author

Ok, who wants to be the magic approving review?

@steveoh
Copy link
Member

steveoh commented Aug 18, 2021

Ok, who wants to be the magic approving review?

me

steveoh
steveoh previously approved these changes Aug 18, 2021
@steveoh steveoh changed the title Sharing Instructions and Detailed Policy Rewrite/Update feat: add sharing instructions and policy refresh Aug 18, 2021
@steveoh steveoh enabled auto-merge (squash) August 18, 2021 22:00
@steveoh steveoh merged commit 2ed3b85 into master Aug 18, 2021
@steveoh steveoh deleted the sharing_submitting branch August 18, 2021 22:01
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants