Skip to content

Conversation

@bboynton97
Copy link
Contributor

agentstack is starting to scale to the point where we might benefit from consistent formatting.

this PR implements Ruff formatting (no functional code changes) and adds a GitHub workflow pre-merge that verifies code is formatted with Ruff

To format your code:

pip install ruff
ruff format .

@bboynton97 bboynton97 requested a review from tcdent December 3, 2024 09:23
@bboynton97
Copy link
Contributor Author

Open to discussion on if formatting is necessary and if this is how we want to implement it

@bboynton97
Copy link
Contributor Author

ignore quote with

ignore = [
    "Q000",  # Single quotes found but double quotes preferred
    "Q001",  # Single quotes found but double quotes preferred (docstring)
    "Q002",  # Single quotes found but double quotes preferred (string)
    "Q003",  # Change outer quotes to avoid escaping inner quotes
]

# Conflicts:
#	agentstack/cli/agentstack_data.py
#	agentstack/cli/cli.py
#	agentstack/generation/tool_generation.py
#	agentstack/utils.py
@bboynton97
Copy link
Contributor Author

formatted files but ignored quotes

@bboynton97 bboynton97 merged commit 9ccdfaa into main Dec 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants