Skip to content

Conversation

@areibman
Copy link
Contributor

@areibman areibman commented Dec 4, 2024

#91

@bboynton97
Copy link
Contributor

Adding tags for agentops is a great idea, but there are a ton of format changes in this PR that will break cookiecutter and need to be reverted

Copy link
Contributor

@bboynton97 bboynton97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@areibman
Copy link
Contributor Author

areibman commented Dec 4, 2024

^

Fixed. Although it doesn't seem we have a standard linter for this, so I ended up auto formatting a bunch of the examples. Ran ruff to make things consistent. We should have a formatter or pre commit like in agentops

@bboynton97
Copy link
Contributor

#82 - discussing it here

@bboynton97
Copy link
Contributor

please remove all formatting changes, its all addressed in #82. i'd rather keep this PR just focused on resolving #92

@areibman
Copy link
Contributor Author

areibman commented Dec 4, 2024

please remove all formatting changes, its all addressed in #82. i'd rather keep this PR just focused on resolving #92

Done!

@areibman areibman requested a review from bboynton97 December 4, 2024 22:35
@bboynton97 bboynton97 merged commit 525c777 into main Dec 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants