Feature/persist browsing data #74
Conversation
…tional-bio/bakrep-web into feature/persist-browsing-data
I get warnings when I use the browse page |
-> Does not go back to first page |
src/views/BrowseView.vue
Outdated
| }); | ||
| } | ||
|
|
||
| function decodeQuery() { |
There was a problem hiding this comment.
This method is named decode, but actually it decodes and replaces the components state. Is there a better name you can use for this behavior?
src/views/BrowseView.vue
Outdated
| watch( | ||
| () => route.query, | ||
| () => { | ||
| populateVariables(); | ||
| }, | ||
| ); |
There was a problem hiding this comment.
Is this required when passing the query via props?
There was a problem hiding this comment.
yes, without it the query values are not properly added to the references, i've tried computed references and those didn't seem to work either, if you know a better way, please let me know!
There was a problem hiding this comment.
Okay, can you add a comment to this block? It should explain why this is done here.
…tional-bio/bakrep-web into feature/persist-browsing-data
…o feature/persist-browsing-data
This error is still there |
…function to updateUrl
… the url immediately
Save filter values in an reactive object instead of single reactive variables Replace `quality` with `completeness` Add comments where it is not clear why something happens Reduce parameters for route-query watcher
Hopefully this improve readability
closes #73